fix(cloudflare): Route DO teardown through original waitUntil#22339
Merged
Conversation
isaacs
requested review from
JPeer264,
andreiborza and
mydea
and removed request for
a team
July 16, 2026 23:51
Avoid a flush-lock deadlock that prevents WebSocket hibernation. fix: #22328 fix: JS-3067
isaacs
force-pushed
the
isaacs/fix-22328-a
branch
from
July 16, 2026 23:54
82884e7 to
11eb627
Compare
andreiborza
approved these changes
Jul 17, 2026
JPeer264
approved these changes
Jul 17, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
Amazing thank you.
By any chance did you find a way to reproduce this in the deployed version? I wonder if there is a reliable way for us to replicate that in wrangler tests or in a prod instance.
Member
Author
No, but to be fair, I didn't try very hard. It was clear from reading the code and the synthetic test that it could happen this way, and the report in #22328 makes it clear it is happening for at least some users. It sounds like it only occurs under load, so I figured it might be tricky to reproduce organically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid a flush-lock deadlock that prevents WebSocket hibernation.
fix: #22328
fix: JS-3067
fix: #21153
fix: JS-2607